feat: generate ibmflashsystemiscsi charm#753
Open
ahmad-can wants to merge 3 commits intocanonical:mainfrom
Open
feat: generate ibmflashsystemiscsi charm#753ahmad-can wants to merge 3 commits intocanonical:mainfrom
ahmad-can wants to merge 3 commits intocanonical:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new Sunbeam storage backend implementation for IBM FlashSystem over iSCSI, and wires it into the unit-test backend matrix so it’s exercised alongside existing backends.
Changes:
- Introduces
IbmflashsystemiscsiBackendand its Pydantic config model. - Adds backend-specific unit tests for IBM FlashSystem iSCSI config/type behavior.
- Extends shared backend fixtures and common backend expectation tests to include the new backend.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
sunbeam-python/sunbeam/storage/backends/ibmflashsystemiscsi/backend.py |
New backend + config model (protocol enum, charm metadata, config schema). |
sunbeam-python/sunbeam/storage/backends/ibmflashsystemiscsi/__init__.py |
New backend package marker/docstring. |
sunbeam-python/tests/unit/sunbeam/storage/backends/conftest.py |
Adds ibmflashsystemiscsi_backend fixture and includes it in any_backend. |
sunbeam-python/tests/unit/sunbeam/storage/backends/test_common.py |
Extends uniqueness and expected-value checks for type/charm name to include IBM backend. |
sunbeam-python/tests/unit/sunbeam/storage/backends/test_ibmflashsystemiscsi.py |
New IBM backend tests + protocol validation checks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ahmad-can
force-pushed
the
feature/generate-ibmflashsystemiscsi-charm
branch
from
a1f8993 to
5191fa8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Charm https://review.opendev.org/c/openstack/sunbeam-charms/+/983822